add(FR-9): autoscaling feature UI in model service creation/modification panel #3024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.69% (-0.03% 🔻) |
400/8534 |
| 🔴 | Branches | 4.06% (-0.05% 🔻) |
239/5886 |
| 🔴 | Functions | 2.84% (-0.04% 🔻) |
78/2747 |
| 🔴 | Lines | 4.61% (-0.03% 🔻) |
385/8351 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / AutoScalingRuleEditorModal.tsx |
0% | 0% | 0% | 0% |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / InputNumberWithSlider.tsx |
4.55% (-0.45% 🔻) |
0% | 0% | 4.55% (-0.45% 🔻) |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 419be5e
lizable
force-pushed
the
feature/model-service-autoscaling
branch
from
9fbef16 to
a229465
Compare
github-actions
bot
added
area:ux
lizable
force-pushed
the
feature/model-service-autoscaling
branch
from
a229465 to
8c2825f
Compare
yomybaby
reviewed
Feb 5, 2025
yomybaby
requested changes
Feb 5, 2025
agatha197
requested changes
Feb 6, 2025
There was a problem hiding this comment.
I can't make a new rule if the name is same as the one that previously deleted.
https://github.com/user-attachments/assets/388a7640-0340-4635-9602-abbe0f3a40ba
agatha197
requested changes
Feb 6, 2025
lizable
changed the title
lizable
changed the title
lizable
changed the title
lizable
force-pushed
the
feature/model-service-autoscaling
branch
from
95da7a6 to
5fe60d0
Compare
agatha197
force-pushed
the
feature/model-service-autoscaling
branch
3 times, most recently
from
8998bf3 to
128e942
Compare
yomybaby
requested changes
Feb 7, 2025
agatha197
force-pushed
the
feature/model-service-autoscaling
branch
from
128e942 to
ee1e261
Compare
agatha197
force-pushed
the
feature/model-service-autoscaling
branch
2 times, most recently
from
71f06f7 to
6268a28
Compare
yomybaby
force-pushed
the
feature/model-service-autoscaling
branch
2 times, most recently
from
136bf9d to
1fca264
Compare
agatha197
force-pushed
the
feature/model-service-autoscaling
branch
from
1fca264 to
eabb67e
Compare
agatha197
force-pushed
the
feature/model-service-autoscaling
branch
2 times, most recently
from
97bb040 to
38d141b
Compare
yomybaby
requested changes
Feb 7, 2025
Merge activity
|
…ion panel (#3024) <!-- Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes, and how it affects the users and other developers. --> This PR resolves applying UI for a new key feature, "applying auto scaling rule" for each model service, which allows gradual update of the volume of model service (mostly routing(session)) according to the rule(s). PLEASE REMIND THAT it's the user matters to consider the consequences of applying the rules, for now. In this PR, there's a new panel added in service detail page, and user can add auto scaling rule by clicking "Add Rules" on the right side of panel. After input all required in popped up modal, and click "OK" button, the rule will be applied immediately to service.  If user want to edit certain rule, then clicking the `gear` icon in corresponding row will do. The Rest of the rule applying mechanism would be same as creation.  When user want to delete a rule, then user just need to click the red `trash bin` icon next to the `gear` icon. After clicking the button, there's a confirmation popup modal appears, and clicking `Delete` button will remove the rule right away.  ### How to test > Prerequisites: > - model-service enabled Backend.AI Core environment - [ ] 1. User can create auto scaling rule for each service. - [ ] 2. User can see auto scaling rule(s) in service detail(routing info) page. - [ ] 3. User can update auto scaling rule. - [ ] 4. User can delete auto scaling rule. **Checklist:** (if applicable) - [ ] Mention to the original issue - [ ] Documentation - [ ] Minimum required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [X] Test case(s) to demonstrate the difference of before/after
graphite-app
bot
force-pushed
the
feature/model-service-autoscaling
branch
from
9aeab1b to
419be5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves applying UI for a new key feature, "applying auto scaling rule" for each model service, which allows gradual update of the volume of model service (mostly routing(session)) according to the rule(s). PLEASE REMIND THAT it's the user matters to consider the consequences of applying the rules, for now.
In this PR, there's a new panel added in service detail page, and user can add auto scaling rule by clicking "Add Rules" on the right side of panel. After input all required in popped up modal, and click "OK" button, the rule will be applied immediately to service.
If user want to edit certain rule, then clicking the
gearicon in corresponding row will do. The Rest of the rule applying mechanism would be same as creation.When user want to delete a rule, then user just need to click the red
trash binicon next to thegearicon. After clicking the button, there's a confirmation popup modal appears, and clickingDeletebutton will remove the rule right away.How to test
Checklist: (if applicable)